Calendar Domain 작성 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjhjack
added
Type: ✨ Feature
Closed
jiwon83
reviewed
Sep 14, 2024
...n/jpa-calendar-domain/src/main/java/com/wypl/jpacalendardomain/calendar/domain/Calendar.java
Show resolved
Hide resolved
...n/jpa-calendar-domain/src/main/java/com/wypl/jpacalendardomain/calendar/domain/Calendar.java
Outdated
Show resolved
Hide resolved
...calendar-domain/src/main/java/com/wypl/jpacalendardomain/calendar/domain/MemberCalendar.java
Show resolved
Hide resolved
...a-calendar-domain/src/main/java/com/wypl/jpacalendardomain/schedule/domain/ScheduleInfo.java
Show resolved
Hide resolved
...n/jpa-calendar-domain/src/main/java/com/wypl/jpacalendardomain/schedule/domain/Schedule.java
Show resolved
Hide resolved
...jpa-calendar-domain/src/main/java/com/wypl/jpacalendardomain/schedule/domain/Repetition.java
Outdated
Show resolved
Hide resolved
...lendar-domain/src/main/java/com/wypl/jpacalendardomain/calendar/domain/MemberCalendarId.java
Show resolved
Hide resolved
KIMSEI1124
requested changes
Sep 14, 2024
|
|
||
| @Column(length = 6, nullable = false) | ||
| @ColumnDefault("Orange") | ||
| private String color; |
There was a problem hiding this comment.
추후에는 이넘 타입으로 관리하고 있는 색상이 있어서 그거로 대체하면 좋을 것 같아요!
...n/jpa-calendar-domain/src/main/java/com/wypl/jpacalendardomain/calendar/domain/Calendar.java
Show resolved
Hide resolved
📄 Image Server Jacoco Coverage Report
|
📄 Image Server Jacoco Coverage Report
|
📄 Image Server Jacoco Coverage Report
|
KIMSEI1124
reviewed
Sep 15, 2024
|
|
||
| @Column(name = "creator_id") | ||
| private Long creatorId; | ||
|
|
There was a problem hiding this comment.
논의를 해봐야할 것 같지만, 그룹에 있는 모든 인원들이 수정을 해야한다고 생각하지만 이 상황이라면 마지막에 수정한 사람이 누구인지 모를 것 같습니다!...
추후 논의 할 수 있도록 다른 곳에 올려둘게요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 개요
✅ PR 체크리스트
🚀 상세 작업 내용
모든 Entity의
extends BaseEntity부분은 Todo 로 작성했습니다.- 복합키를 위한 MemberCalendarId 작성
- InviteStatus enum 작성
- RepetitionCycle enum 작성
📁 ETC