Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findMemberIdAfterSaveMember 메서드와 관련된 로직과 도메인을 분리한다. #67

Closed
sjhjack opened this issue Jan 25, 2025 · 0 comments · Fixed by #68
Closed

findMemberIdAfterSaveMember 메서드와 관련된 로직과 도메인을 분리한다. #67

sjhjack opened this issue Jan 25, 2025 · 0 comments · Fixed by #68
Assignees
@sjhjack
Labels
Module: Auth Domain Module: Core Server Status: In Progress Type: ♻️ Refactor 코드 리팩토링

Comments

@sjhjack
Copy link
Contributor

sjhjack commented Jan 25, 2025 •
edited
Loading

📑 개요

🚀 상세 작업 내용

  • 메서드 명 변경
  • findMemberIdAfterSaveMember 메서드 관련 로직 분리 및 연관된 도메인 구조 변경
  • 변경 사항 반영하여 테스트 코드 재작성

⏰ 예상 소요 시간

5시간

📁 ETC
@sjhjack sjhjack self-assigned this Jan 25, 2025
@sjhjack sjhjack moved this to 🚀 In Progress in What's Your Plan Jan 25, 2025
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Move(#67): findMemberIdAfterSaveMember 위치 변경
5d38298
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Rename(#67): findMemberIdAfterSaveMember 메서드명 변경
79deff3 
메서드 명이 직관적이지 않다는 피드백을 받았습니다.
이에 After를 Or로 변경합니다.
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Chore(#67): @transactional 추가 및 주석 제거
62b96b3
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Feat(#67): AuthMemberFacade 추가
7d3c360 
AuthService, MemberService, AuthDomainService 간 의존성 제거를 위해 Facade Layer 추가
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Refactor(#67): saveAuthData 메서드 리펙토링
a7f4358 
AuthDomainServiceImpl -> MemberServiceImpl 위치 변경
public -> private 변경
saveAuthData -> saveNewMember 메서드명 변경
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Feat(#67): TokenService 추가 및 Token Domain 의존성 추가
64086ff
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Refactor(#67): TokenService 변경사항 적용
7abef25
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Refactor(#67): AuthMemberFacade 적용
9927e9b
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Refactor(#67): TokenService 적용
694ea96
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Chore(#67): 코드 순서 변경
504facf
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Refactor(#67): Facade Layer 추가로 인한 테스트 코드 변경
3116c26 
Facade Layer 추가와 AuthDomainService의 제거로 인해 전체적인 코드가 변경되었습니다.
따라서 기존에 작성했던 테스트 코드를 변경 사항에 맞게 재작성했습니다.
또한, 기존 AuthServiceImpl -> AuthMemberFacadeImpl 로 클래스 명이 변경됨으로 인해 AuthServiceImplTest -> AuthMemberFacadeImplTest 로 변경했습니다.
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Chore(#67): 안 쓰는 파일 임시 주석처리
12c3001
@sjhjack sjhjack changed the title findMemberIdAfterSaveMember 메서드를 분리한다. findMemberIdAfterSaveMember 메서드와 관련된 로직과 도메인을 분리한다. Jan 26, 2025
sjhjack added a commit that referenced this issue Jan 26, 2025
@sjhjack
Chore(#67): 삭제 예정 파일 임시 주석처리
5ae5838
@sjhjack sjhjack mentioned this issue Jan 26, 2025
Merged
10 tasks
sjhjack added a commit that referenced this issue Jan 28, 2025
@sjhjack
Chore(#67): interface의 public 제거
a9e23a1
sjhjack added a commit that referenced this issue Jan 31, 2025
@sjhjack
Rename(#67): class name 변경
143b42a 
인터페이스가 없는 클래스의 클래스 명에서 impl을 제거합니다.
sjhjack added a commit that referenced this issue Jan 31, 2025
@sjhjack
Chore(#67): parameter에 final 키워드 추가
c0ea9a9
sjhjack added a commit that referenced this issue Jan 31, 2025
@sjhjack
Chore(#67): parameter에 final 키워드 추가
d99b23e
sjhjack added a commit that referenced this issue Feb 8, 2025
@sjhjack
Merge branch 'dev' into feat/#67
9e24966
sjhjack added a commit that referenced this issue Feb 8, 2025
@sjhjack
Merge pull request #68 from What-s-Your-Plan/feat/#67
534d9cf 
Refactor: findMemberIdAfterSaveMember 메서드와 관련된 로직과 도메인을 분리
@github-project-automation github-project-automation bot moved this from 🚀 In Progress to ✅ Done in What's Your Plan Feb 8, 2025
@sjhjack sjhjack mentioned this issue Feb 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjhjack sjhjack

Labels
Module: Auth Domain Module: Core Server Status: In Progress Type: ♻️ Refactor 코드 리팩토링
Projects
What's Your Plan
Status: ✅ Done
Milestone
No milestone
1 participant
@sjhjack