Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WMS-1703] Create PHPArray adapter to cache-factory library #2

Merged
merged 4 commits into from
Feb 26, 2019
Merged

[WMS-1703] Create PHPArray adapter to cache-factory library #2

merged 4 commits into from
Feb 26, 2019

Conversation

kamil-iskierka-westwing-pl
Copy link

No description provided.

crashev
crashev suggested changes Feb 26, 2019
View reviewed changes
Copy link

@crashev crashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also write some tests for this new code please :)

@kamil-iskierka-westwing-pl
Copy link
Author

@crashev test added

crashev
crashev approved these changes Feb 26, 2019
View reviewed changes
Copy link

@crashev crashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crashev crashev requested a review from vortexo February 26, 2019 13:46
@crashev crashev merged commit 4958940 into Westwing-Home-and-Living:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vortexo vortexo vortexo approved these changes

@crashev crashev crashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamil-iskierka-westwing-pl @crashev @vortexo