[Viewport Segments] Per CSS WG resolution move the JavaScript segment…

… property from window.visualViewport to the newly added window.viewport. See w3c/csswg-drafts#9237 (comment) for the full IRC log of the conversation. w3c/csswg-drafts#10564 is the PR adding the segments property part of the CSS Viewport Level 1 specification. There is no functional changes in how the segments property works, tests are updated to reflect the new position. Right now the viewport object is tied to the runtime flag of Viewport Segments because we expect the feature to ship before the viewport attribute receive more fields. Bug: 40113439 Change-Id: Ic0624314ee4300899e9e6e98f009e0b4f1fe9655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5783999 Commit-Queue: Alexis Menard <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1344484}
Westbrook · Aug 21, 2024 · dd201c6 · dd201c6
1 parent 2daed40
commit dd201c6
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 15 deletions.
diff --git a/viewport/META.yml b/viewport/META.yml
@@ -0,0 +1,4 @@
+spec: https://drafts.csswg.org/css-viewport-1/
+suggested_reviewers:
+  - bokand
+  - chrishtr
diff --git a/viewport/WEB_FEATURES.yml b/viewport/WEB_FEATURES.yml
@@ -0,0 +1,3 @@
+features:
+- name: viewport
+  files: "**"
diff --git a/viewport/viewport-segments.html b/viewport/viewport-segments.html
@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>Viewport Segments: viewport.segments</title>
+<link rel="help" href="https://drafts.csswg.org/css-viewport-1/"/>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script>
+"use strict";
+
+test(() => {
+  assert_true('segments' in viewport, "`segments` must be a property of viewport.");
+  assert_equals(viewport.segments, null, "For a viewport not segmented, no segments must be exposed.");
+});
+</script>
diff --git a/visual-viewport/viewport-segments.tentative.html b/visual-viewport/viewport-segments.tentative.html