Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
notifications: Match on realm URL .origin, not .href.
We had a steady stream of errors in Sentry caused by differences between the `known_urls` and `realm_uri`, where one of those had an extra `/` on the end (or some more surprising junk, such as a `/join/` link) [1]. Since we don't support running Zulip on a non-root path [2], we can simply compare the domain instead of the href. This is probably more of a band-aid than a real fix (we should figure out how the strange values get into `known_urls` and fix that), but we might as well just check the domain, since the path doesn't matter. Related: zulip#4309. [1] zulip#4309 (comment) [2] https://chat.zulip.org/#narrow/stream/3-backend/topic/support.20for.20running.20on.20non-webroot.20url.3F
- Loading branch information