Make Imhex buildable for MacOS arm64 #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Links that may be useful for that next PR: |
WerWolv
pushed a commit
that referenced
this pull request
Nov 11, 2023
WerWolv
pushed a commit
that referenced
this pull request
Nov 11, 2023
Merged
WerWolv
added a commit
that referenced
this pull request
Nov 16, 2023
I said I'll do it in #1414 Warning: the output zip does not pass SIP (System Integrity Protection), and I have no plan to do it for now. So if someone here has a Mac, feel free to to try to fix the problem (which is probably our build system) Link #1109 --------- Co-authored-by: Nik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps with #1109 but does not fix it
This PR only fix minor things in ImHex, and adds build Dockerfiles to allow you to obtain a .app folder with MacOS arm64 code (currently packaged in an ISO file)
What still needs to be done (in another PR):
Package the .app in a dmg (apparently the current packaging doesn't work on some setups (e.g. @StArBoY-Works)
Sign it
Context: MacOS wants all arm64 code to be signed (but it does not need to be a key associated with a Developer ID AFAIK). Right now the binaries seems to be signed, but the signature are invalidated by the
install_name_toolcommand invoked after. This command seems to be invoked fromImHex/cmake/build_helpers.cmake
Line 243 in 6e6c5c4
Example warning message:
/usr/bin/install_name_tool: warning: changes being made to the file will invalidate the code signature in: /mnt/ImHex/build/imhex.app/Contents/MacOS/plugins/script_loader.hexplug