Added SSL stream context options #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @llemoine , Best regards & happy coding, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As mentioned in this issue #238 , I added a way to set SSL related stream context options.
I only added the SSL stream context options, as the only other available stream context options for the imap protocol are the socket options, which I found very specifics (way more than the SSL ones).
I tested the feature with a few Dovecot Docker containers with custom CA or unsecure TLS version.
It works as intended to specify a CA file or a list of ciphers.
I did not set a closed list of SSL options, as from my tests, if an unknown SSL options, or if a wrong value is passed to
stream_context_create(), it will be ignored.However, if needed, it is possible to restrict the options names and check the value types.
Kind regards,