Not all attachments are pushed to the collection #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem with fetch all attachments. Some attachments are not added to the collection. Checking attachment ID before add it to collection solved the problem in my case.
Fix for saving all attachments from them messages.
This was referenced Feb 12, 2023
|
Hi @AdrianKuriata , Thanks again and best regards, |
gitstashgithub
pushed a commit
to gitstashgithub/php-imap
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a problem with fetching all attachments from the email (v4 - I don't know abount other versions). In example I have 7 attachments on the email, but randomly getting 5 or 6 attachments. I don't know, maybe problem is with text attachments, because I have a problem only with text attachments, but this patch solvs the problem. I can't reproduce this problem and can't share my issue, because it is private data. You can try to get email message with 10 attachments with different types, maybe you will reproduce it. Is possible to fast merge this pull request?
There is a hotfix and tag for v4 which I using in project to solve this problem https://github.com/AdrianKuriata/php-imap/tree/4.1.2-hotfix https://github.com/AdrianKuriata/php-imap/tree/4.1.2.2