Fix use of ST_MSGN as sequence method #356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we upgraded from version 2.7.2 to 4.1.0 of this library we noticed bugs and sneaky behaviours using the sequence method ST_MSGN.
We think that these two issues suffered the same behaviours that we noticed:
We checked the differences among old version and new version. We found that the main issue regards the use of the $uid variable in the "fetch" method of the ImapProtocol class. The old version used that variable as a boolean while the new code treats it sometimes as bool and sometimes as int|string.
This pull request restored the old behaviour and with these changes we can see our code started work again.
Can you please check it and understand if you want to merged it in the master branch?