Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when creating folders with special chars #319

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Fix error when creating folders with special chars #319

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4ffe25
Fix error when creating folders with special chars
thin-k-design Nov 7, 2022
1593502
Update return types of getFolder methods to Folder|null
thin-k-design Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ public function disconnect(): Client {
* @param string $folder_name
* @param string|bool|null $delimiter
*
* @return mixed
* @return Folder|null
* @throws ConnectionFailedException
* @throws FolderFetchingException
* @throws Exceptions\RuntimeException
Expand All @@ -434,7 +434,7 @@ public function getFolder(string $folder_name, $delimiter = null) {
* Get a folder instance by a folder name
* @param $folder_name
*
* @return mixed
* @return Folder|null
* @throws ConnectionFailedException
* @throws FolderFetchingException
* @throws Exceptions\RuntimeException
Expand All @@ -447,7 +447,7 @@ public function getFolderByName($folder_name) {
* Get a folder instance by a folder path
* @param $folder_path
*
* @return mixed
* @return Folder|null
* @throws ConnectionFailedException
* @throws FolderFetchingException
* @throws Exceptions\RuntimeException
Expand Down Expand Up @@ -570,7 +570,7 @@ public function createFolder(string $folder, bool $expunge = true): Folder {

if($expunge) $this->expunge();

$folder = $this->getFolder($folder);
$folder = $this->getFolderByPath($folder);
if($status && $folder) {
$event = $this->getEvent("folder", "new");
$event::dispatch($folder);
Expand Down