fix inline attachments and embedded images #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dwalczyk , |
|
This change broke message bodies completely. Getting a completely empty bodies array for almost all of the messages in my folder. How did this change even make it to production?? |
|
Hi @hadesflames , Please keep in mind that no one is getting paid for their contribution - we are all just doing it for each other. I'm grateful for every pull request. Please take a look at the license and read it carefully (note the limitations). Perhaps your expectations towards open source software are a bit off? Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My fix for MessageMask->getHTMLBodyWithEmbeddedBase64Images() - now will working correctly :)
Tested on gmail and outlook.
Additionally I added: