Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to parse time string #192

Closed
mahoho opened this issue Feb 1, 2019 · 2 comments
Closed

Failed to parse time string #192

mahoho opened this issue Feb 1, 2019 · 2 comments

Comments

@mahoho
Copy link

mahoho commented Feb 1, 2019

Hello!
I have felt with a crashing on dates:
DateTime::__construct(): Failed to parse time string (Mon, 28 1 14:6:5-0500) at position 5 (2): Unexpected character.

Format is very confusing and I think it will be nice that fetching will simply skip those messages and not crashing whole process.

OS: Windows,
PHP 7.2 x64

@Webklex
Copy link
Owner

Webklex commented Mar 10, 2019

Hi @mahoho ,
Im always amazed to see so many possible ways to srew up a date string^^ However I think a date is not trivial and should fail hard if it can't be passed. Hoever I see your point and think the correct way would be to raise a custom exception such as InvalidMessageDateException::class or so. I will incude it within the next release.

@Webklex
Copy link
Owner

Webklex commented Mar 11, 2019

Hi @mahoho ,
please update to v. 1.3.0 :)

@Webklex Webklex closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants