Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a mechanism to disable the adapter taking control of the dongle serial ports so that zigbee2mqtt can access them #308

Closed
chas-iot opened this issue Mar 25, 2021 · 6 comments

Comments

@chas-iot
Copy link
Contributor

If there is a dongle plugged in that can be used by both zigbee-adapter and zigbee2mqtt then it is not possible to test the new code.

Much more difficult use case: I have two ConBee II dongles, so I could, in theory, attach one to each. However this would require much deeper intervention at the OS level (udev rules) to provide alternate symlink device names and specifically configure zigbee-adapter to use one and zigbee2mqtt to use another.

@tim-hellhake
Copy link
Member

tim-hellhake commented May 29, 2021

I added two new settings which allow you to specify exactly which sticks to use.
Does this solve the problem?

tim-hellhake added a commit that referenced this issue May 29, 2021
Run prettier
Add option to deactivate probing and specify stick manually (#308)
tim-hellhake added a commit that referenced this issue May 29, 2021
Run prettier
Add option to deactivate probing and specify stick manually (#308)
Remove src/manifest.json
tim-hellhake added a commit that referenced this issue May 29, 2021
Run prettier
Add option to deactivate probing and specify stick manually (#308)
Remove src/manifest.json
@chas-iot
Copy link
Contributor Author

It looks like this will do the trick. When do you expect to merge this release into the addon-list?

@tim-hellhake
Copy link
Member

Now 😬

@chas-iot
Copy link
Contributor Author

chas-iot commented Jun 1, 2021

There is a major unannounced backwards compatibility break :(
"Automatic probing of the serial ports" defaults to cleared, which means that anyone non-technical still using the legacy adapter (perhaps with an incompatible dongle) will see all of the zigbee devices stop working with no explanation. This should be widely announced and the description of the setting should help users understand what to do.
I'm busy at day job today, so can't dig in with a patch

@tim-hellhake
Copy link
Member

It looks like the default value has no effect.
I converted the activate flag to a reactive flag, so probing is activated unless explicitly deactivated.

tim-hellhake added a commit that referenced this issue Jun 1, 2021
Fix 'Cannot find module ./manifest.json' (#314)
Convert probing activate flag to deactivate flag (#308)
@tim-hellhake
Copy link
Member

As soon as the build is finished I release the fix.

tim-hellhake added a commit that referenced this issue Jun 1, 2021
Fix 'Cannot find module ./manifest.json' (#314)
Convert probing activate flag to deactivate flag (#308)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants