Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/promisify-properties #150

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Feature/promisify-properties #150

wants to merge 7 commits into from

Conversation

0815fox
Copy link

@0815fox 0815fox commented Oct 6, 2021

  1. Changed set and get methods including valueForwarder to Promise logic.
  2. Added optional valueRequestor. If set it is called for a get request on a property value.

npm run test probably already failed before.

This branch also contains the changes from PR #148

mkr added 3 commits October 5, 2021 10:32
make code compile with tsc 4.4.3
3564973
Promisified property handling.
7659828 
Add valueRequestor for the case when a value has to be requested asynchronously.
Corrections for eslint
658bd43
@0815fox 0815fox mentioned this pull request Oct 6, 2021
Open
tim-hellhake
tim-hellhake requested changes Oct 10, 2021
View reviewed changes
Copy link
Member

@tim-hellhake tim-hellhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run prettier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-hellhake tim-hellhake tim-hellhake requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0815fox @tim-hellhake