Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3C compliant properties protocol binding #2875

Merged

Conversation

benfrancis
Copy link
Member

@benfrancis benfrancis commented Sep 20, 2021

This is a replacement for #2868 which makes the properties part of the gateway's API W3C compliant and is a partial fix to #2807. Unlike #2868, set property operations still have a payload in their response since it turns out the front end depends on this.

  • Remove object wrapper from property API requests (to make API payloads directly match property data schema in Thing Descriptions)
  • Update the front end to consume the new API
  • Fix the litany of failing integration tests as a result of changing the API

@benfrancis benfrancis marked this pull request as draft September 20, 2021 17:14
@benfrancis benfrancis changed the title Properties protocol binding W3C compliant properties protocol binding Sep 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #2875 (0a65023) into master (7a4c641) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

❗ Current head 0a65023 differs from pull request most recent head 5f0b6ba. Consider uploading reports for the commit 5f0b6ba to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2875      +/-   ##
==========================================
- Coverage   65.30%   65.30%   -0.01%     
==========================================
  Files         124      124              
  Lines        7987     7984       -3     
  Branches     1320     1320              
==========================================
- Hits         5216     5214       -2     
+ Misses       2729     2728       -1     
  Partials       42       42              
Impacted Files Coverage Δ
src/controllers/things_controller.ts 79.48% <85.71%> (-0.84%) ⬇️
src/app.ts 56.32% <100.00%> (ø)
src/test/browser/test-utils.ts 95.12% <100.00%> (ø)
src/controllers/internal_logs_controller.ts 84.21% <0.00%> (-1.76%) ⬇️
src/models/thing.ts 69.20% <0.00%> (+0.38%) ⬆️
src/models/things.ts 76.68% <0.00%> (+1.22%) ⬆️
src/controllers/new_things_controller.ts 46.15% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4c641...5f0b6ba. Read the comment docs.

@benfrancis benfrancis force-pushed the properties-protocol-binding2 branch from fdd99de to 5f0b6ba Compare September 22, 2021 13:42
@benfrancis benfrancis marked this pull request as ready for review September 22, 2021 13:44
@benfrancis benfrancis requested a review from relu91 September 22, 2021 13:44
@benfrancis
Copy link
Member Author

OK, I finally got all the tests to pass which was a bit of a mission. Ready for review.

@benfrancis benfrancis merged commit 6ed212a into WebThingsIO:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants