-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
W3C compliant actions protocol binding #2871
W3C compliant actions protocol binding #2871
Conversation
e41dab5
to
7bcd592
Compare
Codecov Report
@@ Coverage Diff @@
## master #2871 +/- ##
==========================================
+ Coverage 65.30% 65.40% +0.09%
==========================================
Files 124 124
Lines 7987 7974 -13
Branches 1320 1317 -3
==========================================
- Hits 5216 5215 -1
+ Misses 2729 2717 -12
Partials 42 42
Continue to review full report at Codecov.
|
I've fixed the integration tests and this is now ready for review. What this PR does:
What this PR does not do:
My thinking is that in this first phase we will just make the In a later phase we can fully implement the new actions protocol binding from the WoT Profile specification and also expose Note that we will need to add the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections! looks good.
This is an implementation to make the invoke action part of the gateway's API W3C compliant and is a partial fix to #2807.
My current thinking is to leave the rest of the API intact until the proposed action protocol binding for WoT Profile is finalised, so that we don't have to implement it twice. The first step is to simply make the
invokeaction
operation API match the Thing Description.One thing I'm not sure about is what to do with the /actions endpoint where no action name is specified in the URL, but one option is to leave it as it is and just remove that endpoint from Thing Descriptions until the Thing Description specification has a way to describe it (see w3c/wot-thing-description#1200).