Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, while working on #2811 a stumble upon a random timeout in the test. As described in #2837 I think the problem is when the virtual-adapter plug-in is installed. This PR fixes #2837 by blocking further adapter additions when the plug-in already got an unload request. Furthermore, it now fails gracefully when
unload
is called more than once.Finally, I also "improved" the log tests. Basically, in my system, it failed when you already executed the tests (like one day before), because it had a wrong log file count. Now it clears the log folder to have a clean state. Let's hope that now we have a green light 🤞🏻