Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Rebuild thing-url-adapter #1441

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Oct 23, 2018

Adapter is rebuild from source in container,
this was needed for node10 supprt.

It was tested on ARTIK710 on fedora

Change-Id: I473236d34bf92abec6d216cfce6f09d5d38efe30
Signed-off-by: Philippe Coval [email protected]

Adapter is rebuild from source in container,
this was needed for node10 supprt.

It was tested on ARTIK710 on Fedora.

Change-Id: I473236d34bf92abec6d216cfce6f09d5d38efe30
Forwarded: WebThingsIO#1441
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/devel/build/review/master branch from 9a64bf0 to 8ca49c1 Compare October 23, 2018 19:51
@mrstegeman
Copy link
Contributor

We currently only fully support v8, as it's LTS. We have #1122 open so that we can fix this in a more general way for all add-ons. It will probably require changes to our add-on list format again.

@mrstegeman
Copy link
Contributor

@rzr Have you gotten thing-url-adapter to work with node v10? I've found an issue where bluetooth-hci-socket won't build with v10.

@rzr
Copy link
Contributor Author

rzr commented Oct 29, 2018

yea same
I I have too but you can workaround it using:

    npm install "https://github.com/jrobeson/node-bluetooth-hci-socket/#fix-builds-for-node-10" # worked

More details to come for artik7 support

https://github.com/rzr/webthing-iotjs/wiki/Gateway

@mrstegeman
Copy link
Contributor

Ok. I'm working on getting proper node v10 support, so this PR should become unnecessary.

@rzr
Copy link
Contributor Author

rzr commented Nov 8, 2018

hi @mrstegeman any progress on

noble/node-bluetooth-hci-socket#91 ?

@mrstegeman
Copy link
Contributor

Unfortunately, no. The whole noble project seems to be unmaintained at the moment, which is very frustrating.

However, we do now have proper support in the gateway for Node v10 add-ons (other than thing-url-adapter and homekit-adapter, as both use noble).

rzr added a commit to TizenTeam/node-eddystone-beacon-scanner that referenced this pull request Dec 19, 2018
Change-Id: I60e9efb6056dee9f34798600b602d310c9f858eb
Relate-to: WebThingsIO/gateway#1441
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit to TizenTeam/node-eddystone-beacon-scanner that referenced this pull request Dec 19, 2018
Change-Id: I60e9efb6056dee9f34798600b602d310c9f858eb
Relate-to: WebThingsIO/gateway#1441
Forwarded: sandeepmistry#26
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit to TizenTeam/thing-url-adapter that referenced this pull request Dec 19, 2018
Relate-to: WebThingsIO/gateway#1441
Change-Id: Ic26a50205a2c8cc5593c23cc466f394584b3c5a3
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit to TizenTeam/thing-url-adapter that referenced this pull request Dec 19, 2018
Relate-to: WebThingsIO/gateway#1441
Forwarded: WebThingsIO#64
Change-Id: Ic26a50205a2c8cc5593c23cc466f394584b3c5a3
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit to TizenTeam/thing-url-adapter that referenced this pull request Dec 20, 2018
Relate-to: WebThingsIO/gateway#1441
Forwarded: WebThingsIO#64
Change-Id: Ic26a50205a2c8cc5593c23cc466f394584b3c5a3
Signed-off-by: Philippe Coval <[email protected]>
@mrstegeman mrstegeman removed the review label Apr 3, 2019
@mrstegeman
Copy link
Contributor

I'm going to close this. We have node v10 support, but noble is still broken.

@mrstegeman mrstegeman closed this Apr 4, 2019
@rzr
Copy link
Contributor Author

rzr commented Apr 5, 2019

I can have a look at noble ...

@mrstegeman
Copy link
Contributor

It's possible that things work now with @abandonware/eddystone-beacon-scanner, but I've not tried yet. Have you tried it, by chance?

@rzr
Copy link
Contributor Author

rzr commented Apr 5, 2019

no yet, I can give a try in a couple of weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants