Make changes to device schema for W3C compliance - partial fix for #20 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfrancis
force-pushed
the
w3c-compliance
branch
from
82e05ab to
ebca8cb
Compare
benfrancis
force-pushed
the
w3c-compliance
branch
from
ebca8cb to
96c5bcf
Compare
relu91
approved these changes
Sep 29, 2021
messages/definitions.json
Outdated
| "description": "An array of JSON-LD contexts used by the device" | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
With this change we can support these two context types: @context : "URL" and @context : ["url", "url"]
What about:
@context : [ "url", { myprefix : "url"}]
There was a problem hiding this comment.
Ah OK, so we need something more like this? https://github.com/w3c/wot-scripting-api/blob/main/typescript/thing-description/schema/td-json-schema-validation.json#L70
There was a problem hiding this comment.
How's this? (pushed another commit)
benfrancis
changed the title
tim-hellhake
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.