W3C compliance - Use forms instead of links in Properties, Actions, and Events #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also WebThingsIO#2806
See also #2806
to be consistent with the other affordances
See also #2806
tim-hellhake
approved these changes
May 13, 2021
LiberalArtist
added a commit
to LiberalArtist/webthings-gateway-addon-node
that referenced
this pull request
Nov 24, 2021
This commit fixes the schema submodule to refer to the version of WebThingsIO/gateway-addon-ipc-schema#18 that was ultimately merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is one of the first steps to achieve compliance with the current W3C Thing Description specification. This PR renames links to forms in property, actions, and events JSON schemas.
See WebThingsIO/gateway#2806 for context and rationale.
One comment, in the long run, it might be more convenient to use directly the JSON schema published by the w3c so that we don't need to manually copy over the changes between versions. However, I think that during this transition phase we could incrementally update the schemas here.