Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add null to stringify type definition #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quangv
Copy link

@quangv quangv commented Apr 19, 2024

Comparing the jsdoc type in index.js to types/index.d.ts seems like null is missing for stringify, 2nd argument.

* @param {((this: any, key: string, value: any) => any) | (string | number)[] | null | undefined} [replacer]

@WebReflection
Copy link
Owner

isn't that covered by replacer? ... or maybe not? 🤔 true that you can pass null, if you confirm that's an issue in TS I might change that and accept your PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants