Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ECDSA_256r1N in condition when checking if code is transferable #148

Merged
merged 2 commits into from
May 23, 2023
Merged

add ECDSA_256r1N in condition when checking if code is transferable #148

merged 2 commits into from
May 23, 2023

Conversation

Arsh-Sandhu
Copy link
Contributor

No description provided.

qui-jason
qui-jason previously approved these changes May 22, 2023
View reviewed changes
Copy link

@qui-jason qui-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! @pfeairheller not sure if this was also missed in the KERIpy work, I know you initially took a look at my changes when creating that branch

jasoncolburne
jasoncolburne previously approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@jasoncolburne jasoncolburne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, wrong account. LGTM

@jasoncolburne
Copy link
Collaborator

@Arsh-Sandhu Looks like you need to run cargo fmt. Also, you probably want to run the make preflight command to ensure things are going to pass CI. Would you mind also bumping the version in Cargo.toml to 0.6.1?

@Arsh-Sandhu
Copy link
Contributor Author

Thanks for catching this! @pfeairheller not sure if this was also missed in the KERIpy work, I know you initially took a look at my changes when creating that branch

I fixed this in KERIpy, added ECDSA_256r1N in NonTransCodex class

Commit d78d762

@Arsh-Sandhu
Copy link
Contributor Author

@Arsh-Sandhu Looks like you need to run cargo fmt. Also, you probably want to run the make preflight command to ensure things are going to pass CI. Would you mind also bumping the version in Cargo.toml to 0.6.1?

sure

m00sey
m00sey previously approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Arsh-Sandhu
fix format and updated version
3874701 
Signed-off-by: arshdeep singh <[email protected]>
@Arsh-Sandhu Arsh-Sandhu dismissed stale reviews from m00sey, jasoncolburne, and qui-jason via 3874701 May 22, 2023 17:04
@Arsh-Sandhu Arsh-Sandhu requested a review from jasoncolburne May 23, 2023 02:56
@m00sey m00sey merged commit 2b2a39f into WebOfTrust:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00sey m00sey m00sey approved these changes

@qui-jason qui-jason qui-jason left review comments

@jasoncolburne jasoncolburne Awaiting requested review from jasoncolburne jasoncolburne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Arsh-Sandhu @jasoncolburne @m00sey @qui-jason