Implement the <search> element #13887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
added
the
DOM
|
EWS run on previous version of this PR (hash a136b01) |
annevk
commented
May 15, 2023
|
Looks good to me, but I think someone from AX should sign off on the picked role |
|
The role matches how we map |
nt1m
approved these changes
May 15, 2023
webkit-ews-buildbot
added
the
merging-blocked
cookiecrook
approved these changes
May 15, 2023
annevk
force-pushed
the
eng/Implement-the-search-element
branch
from
a136b01 to
26e4ebf
Compare
|
EWS run on current version of this PR (hash 26e4ebf) |
https://bugs.webkit.org/show_bug.cgi?id=254327 rdar://107175819 Reviewed by Tim Nguyen. Adds the new HTML search element as specified in whatwg/html#7320. Given the code changes are minimal there is no preferences guard. It doesn't address the unicode-bidi rendering requirements as they are not addressed for many elements in WebKit: https://bugs.webkit.org/show_bug.cgi?id=256829 This change also syncs most of WPT html/syntax/parsing and adds accessibility test coverage for the main element. * LayoutTests/accessibility/roles-exposed.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles-iso-8859-8-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles-iso-8859-8.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/Element.getElementsByTagName-foreign-02.html: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/README: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html-integration-point.html: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_innerHTML_template-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_innerHTML_template.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_innerHTML_webkit02-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_innerHTML_webkit02.html: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_search-element.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_search-element_run_type=uri-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_search-element_run_type=write-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_search-element_run_type=write_single-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tables01.html: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tables01_run_type=uri-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tables01_run_type=write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tables01_run_type=write_single-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_template.html: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_template_run_type=uri-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_template_run_type=write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_template_run_type=write_single-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests20.html: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests20_run_type=uri-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests20_run_type=write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests20_run_type=write_single-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit01.html: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit01_run_type=uri-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit01_run_type=write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit01_run_type=write_single-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit02.html: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit02_run_type=uri-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit02_run_type=write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit02_run_type=write_single-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/math-parse03.html: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/test.js: (test_fragment): (convert_innerHTML): * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/w3c-import.log: * LayoutTests/inspector/css/shadow-scoped-style-expected.txt: * LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt: * LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt: * LayoutTests/tests-options.json: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const): * Source/WebCore/css/html.css: (address, article, aside, div, footer, header, hgroup, main, nav, search, section): (address, article, aside, div, footer, header, hgroup, main, nav, section): Deleted. * Source/WebCore/html/HTMLTagNames.in: * Source/WebCore/html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processEndTagForInBody): Canonical link: https://commits.webkit.org/264110@main
webkit-commit-queue
force-pushed
the
eng/Implement-the-search-element
branch
from
26e4ebf to
de16e2b
Compare
|
Committed 264110@main (de16e2b): https://commits.webkit.org/264110@main Reviewed commits have been landed. Closing PR #13887 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 16, 2023
This was added to the HTML spec here: whatwg/html#7320 I mostly based on this on the webkit patch: WebKit/WebKit#13887 Bug: 1294294 Change-Id: Ia34836f7e5172d862a3a1f24f1e5cbcbb10e6a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4767222 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1184358}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
de16e2b
26e4ebf
🧪 ios-wk2-wpt🧪 api-ios