Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all runner resources to dedicated folder #299

Closed

Conversation

camillobruni
Copy link
Contributor

No description provided.

@camillobruni camillobruni added the trivial change A change that doesn't affect benchmark results label Aug 21, 2023
Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me. Please give me heads up before merging this PR since it'd break WebKit's CI without a WebKit side patch as well.

@rniwa
Copy link
Member

rniwa commented Feb 24, 2024

This PR seems abandoned at this point. With so many conflicts, it's probably best to open a new PR if we wanted to make this change. It's probably best not to mess with the directory / file structure this late in the release cycle though. Maybe this is something we can consider for v.4.

@camillobruni
Copy link
Contributor Author

Closing for now and will redo this PR post-launch.

@camillobruni camillobruni deleted the 2023-08-21_move_resources branch August 6, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial change A change that doesn't affect benchmark results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants