Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#53 gutenberg 3 2 compatibility #54

Merged
merged 7 commits into from
Aug 7, 2018

Conversation

jomurgel
Copy link
Contributor

Closes #53

DESCRIPTION

Resolved a couple of issues.

Updated Gutenberg to v3.2 and confirmed that the following blocks are working:

  • Hero
  • Call To Action
  • Github Gist
  • Recent Posts
  • Two Column
  • Users Grid

I was able to confirm that the Related Posts was our problem child. Specifically that it looks as if 3.2 introduced an issue that breaks any use of new WP_Query inside the render.php output. Tested this theory and confirmed.

Submitted an issue over on Gutenberg WordPress/gutenberg#8035 to try and maybe figure out what's going on. There are several related issues around the use of core WP functions not working—get_the_excerpt and the_excerpt use failures to name just one.

I also updated the block_get_excerpt which now works with the foreach loop — and kind of ends up fixing some logic errors.

A couple of unrelated fun facts, ACF 5.6.10 has some conflicts with the wp.hooks call which is resolved by updating to 5.7. These blocks still function as expected with 5.6.10.

SCREENSHOTS

screenshot 2018-07-18 13 10 02
screenshot 2018-07-18 13 10 06
screenshot 2018-07-18 13 10 36

STEPS TO VERIFY

  • Pull branch.
  • Update Gutenberg.
  • Test all blocks.
  • Refresh Page or exist and return.

@jomurgel jomurgel added bugfix Something isn't working R4R Issue or PR ready for review labels Jul 18, 2018
@jomurgel jomurgel requested a review from gregrickaby July 18, 2018 19:24
@jomurgel jomurgel merged commit 6cce44c into master Aug 7, 2018
@gregrickaby gregrickaby deleted the feature/#53-gutenberg-3-2-compatibility branch August 24, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working R4R Issue or PR ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gutenberg v3.2 Compatibility
2 participants