Feature/#53 gutenberg 3 2 compatibility #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53
DESCRIPTION
Resolved a couple of issues.
Updated Gutenberg to v3.2 and confirmed that the following blocks are working:
I was able to confirm that the Related Posts was our problem child. Specifically that it looks as if 3.2 introduced an issue that breaks any use of
new WP_Query
inside therender.php
output. Tested this theory and confirmed.Submitted an issue over on Gutenberg WordPress/gutenberg#8035 to try and maybe figure out what's going on. There are several related issues around the use of core WP functions not working—
get_the_excerpt
andthe_excerpt
use failures to name just one.I also updated the
block_get_excerpt
which now works with theforeach
loop — and kind of ends up fixing some logic errors.A couple of unrelated fun facts, ACF 5.6.10 has some conflicts with the
wp.hooks
call which is resolved by updating to 5.7. These blocks still function as expected with 5.6.10.SCREENSHOTS
STEPS TO VERIFY