Fix/cc 434 optin js reveal #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw2113
added a commit
that referenced
this pull request
Sep 3, 2024
* version bumps * version bump and changelog * Images cleanup (#676) * old image removal * remove old logo flare from "first form" modal * another image removal * update "first form" modal with new images * remove reliance on meta data and instead rely on POST data for lists being used. (#680) * remove reliance on meta data and instead rely on POST data for lists being used. * add phpcs ignores for nonce things * Update social icons in plugin list (#678) * remove google plus which does not exist, remove twitter which does not seem to be working any more. * re-add twitter as X, rename variables, add escaping to our site link value * Fix/cc 434 optin js reveal (#679) * fix optin display while also converting away from jQuery dependency * build copies * handle change events * build files * finish up changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles updating away from jQuery dependency, but also handles re-revealing opt-in fields that we accidentally broke with version 2.6.0 release and the list management changes.