Feature/cc 408 modern block two #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guzmandrade-dev
approved these changes
Jun 11, 2024
tw2113
added a commit
that referenced
this pull request
Jun 12, 2024
* Feature/cc 388 multi list (#671) * early add to eventually render our CSS via our sass process * commit these original non build files for now * eod status for our new attached lists class and custom cmb2 field * current usage of attached posts field * load the file needed for our cmb2 field * switch out CMB2 IDs between the fields * refine arguments and include instructions for our new field * change up cursor based on column. Hide sort dashicon for the available lists column * remove details around type * move early return to the top of the function * strict type checking for event * sass side of dashicon hiding and cursor changing * misc comments and unneeded method removal * render method reworking and cleanup * fetch objects by list id and output as part of associated list * variable renaming and ID return value updates * remove conditional sort dashicon. Remove edit link markup * remove group support. * let instead of var, remove user querying * fix missed opening php tag * we need to set to true to be part of our admin search * update @ since tags to match our forms plugin * create dedicated doing_search method * removed missed spot regarding user seearch * amend retrieved list IDs to actually be post IDs * compiled styles now get added to admin CSS for attached posts sass * remove isolated CSS file as we now compile into admin css * we have moved this into our main assets js folder * moved file and updated naming * update our script enqueuing details for attached lists * these compiled and diffed anew * commenting out the search button for now, in case we want to return in the future. For now the listing should show all available and inline filter works * remove original multicheck * touch up our list metabox to show SOMETHING always, but conditional messaging for no connect vs no lists found. * update current version for branch, update tested up to * Feature/cc 408 modern block two (#672) * reduce our tag list to the recommended 5 max * Redoing a new branch * lock file * assets build * add build copy * Feature/cc 423 review prompts (#673) * reprompt for over 3 dismissals, but only 14 or 30 days after. Re-stop at 5 dismissals * increment how high we save our dismissed count * update changelog and fix typo from last release * fix @SInCE tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh based on the release260 branch.
Convert our block to functional based instead of class based.
Revise and update our overall asset compilation in response to npm changes and structure.