Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detail to security section #271

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

mjwilson-google
Copy link
Contributor

This is to fix #185

@mjwilson-google
Copy link
Contributor Author

@cwilso please take a look. I tried to capture the firmware concerns in an objective way, and tried to reorganize and slightly clean up the previous section while keeping the content.

We will have a security review pass as part of the road to Recommendation, and it doesn't have to be perfect, but all concerns we know about should be included in this section.

@mjwilson-google mjwilson-google requested a review from hoch November 14, 2024 20:43
@hoch
Copy link
Member

hoch commented Nov 14, 2024

Could you add what are being done specifically? It looks like a big change and not sure what to focus on as a reviewer.

Does this handle tasks listed in #185 (comment)?

@mjwilson-google
Copy link
Contributor Author

Sorry, it's implementing the plan in the last comment in the issue:
#185 (comment)

One change from the plan is I use three categories instead of two for the
pre-existing prose, but I think that worked better.

If you would like me to go over it with you in more detail please let me
know.

Copy link
Contributor

@cwilso cwilso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a few comments, and suggested some changes, but overall approved.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@mjwilson-google mjwilson-google merged commit 400deb4 into WebAudio:gh-pages Nov 16, 2024
1 check passed
@mjwilson-google mjwilson-google deleted the security branch November 16, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more detail to security section
3 participants