Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to constructor operations #2051

Closed
Ms2ger opened this issue Aug 29, 2019 · 1 comment · Fixed by #2066
Closed

Update to constructor operations #2051

Ms2ger opened this issue Aug 29, 2019 · 1 comment · Fixed by #2066
Assignees
Labels
Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/
Milestone

Comments

@Ms2ger
Copy link

Ms2ger commented Aug 29, 2019

See whatwg/webidl#778.

@rtoy
Copy link
Member

rtoy commented Sep 4, 2019

The important part is whatwg/webidl#636. Basically, we have

[Exposed=Window,
 Constructor (BaseAudioContext context, optional AnalyserOptions options = {})]
interface AnalyserNode : AudioNode {
...
}

and the proposal is to make this

[Exposed=Window]
interface AnalyserNode : AudioNode {
  constructor(BaseAudioContext context, optional AnalyserOptions options = {});
...
}

@mdjp mdjp added this to the Web Audio V1 milestone Sep 16, 2019
@mdjp mdjp added Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/ and removed Editorial/Documentation labels Sep 16, 2019
padenot added a commit to padenot/web-audio-api that referenced this issue Sep 18, 2019
This fixes WebAudio#2051.

There are still issues with bikeshed and the webidl parser, but it's
largely there. In particular, arguments don't work yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants