Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary encoding of rtt and i31 #25

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix binary encoding of rtt and i31 #25

merged 1 commit into from
Nov 11, 2020

Conversation

binji
Copy link
Member

@binji binji commented Nov 11, 2020

The rtt prefix is 0x69, and i31 is 0x6a (we previously had them
swapped).

The rtt prefix is 0x69, and i31 is 0x6a (we previously had them
swapped).
Copy link

@jakobkummerow jakobkummerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@binji binji merged commit 3d40f65 into master Nov 11, 2020
@binji binji deleted the binary-rtt-vs-i31 branch November 11, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants