Use Abseil; remove fmt/span-lite/phmap #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried using absl a while back and gave up on it. But now it actually seems to be making things simpler! TODO: The formatting functions still use C++ streams, which should be replaced by the absl::str_format library. This means that wasp types need to be wrapped in `concat()` when passing to an absl formatting function.
sbc100
approved these changes
Nov 2, 2020
|
@sbc100 Looking at the circleci build times, it looks like it increases build time somewhat: build-clang-debug: 4:39 -> 5:03 This isn't a perfect measurement, not quite sure if I'm looking at the right numbers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using absl a while back and gave up on it. But now it actually
seems to be making things simpler!
TODO: The formatting functions still use C++ streams, which should be
replaced by the absl::str_format library. This means that wasp types
need to be wrapped in
concat()when passing to an absl formattingfunction.