Assert error on ambiguous fstflags #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a Rust test case that asserts an ambiguous `fstflags` input to `fd_filestat_set_times` should result in `inval` errno. An `fstflags` argument is ambiguous if: 1. both `atim` and `atim_now` are set, or 2. both `mtim` and `mtim_now` are set.
|
Can anyone merge this? |
|
Sorry for missing that, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a Rust test case that asserts an ambiguous
fstflagsinput tofd_filestat_set_timesshould result ininvalerrno. Anfstflagsargument is ambiguous if:atimandatim_noware set, ormtimandmtim_noware set.This assertion is consistent with Wasmtime and WasmEdge's current behavior.