Add wasi-sdk-pthread.cmake to docker image to allow enabling it with env #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
commented
Aug 9, 2023
| @@ -18,6 +18,7 @@ set(CMAKE_AR /usr/bin/llvm-ar-$ENV{LLVM_VERSION}) | |||
| set(CMAKE_RANLIB /usr/bin/llvm-ranlib-$ENV{LLVM_VERSION}) | |||
| set(CMAKE_C_COMPILER_TARGET ${triple}) | |||
| set(CMAKE_CXX_COMPILER_TARGET ${triple}) | |||
| set(CMAKE_ASM_COMPILER_TARGET ${triple}) | |||
There was a problem hiding this comment.
When cribbing from top-level cmake file, I noticed this line was there that hadn't been added here
abrown
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
@sunfishcode and I are here looking at this and this seems OK--let's merge it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBH, I'm not sure what to think of this change as it does seem to bring the number of cmake files in this repo to an incredible level. But the docker image is the easiest way to just try building a repo with WASI (e.g., abseil/abseil-cpp#1509), and being able to just
export CMAKE_TOOKCHAIN_FILE=/usr/share/cmake/wasi-sdk-pthread.cmakewould be a great boon. What do you think?