Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wasi:clocks from include to import in wasi:http/proxy #115

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

yoshuawuyts
Copy link
Member

This changes the wasi:clocks include statement to individual import statements in wasi:http/proxy. This came out of a conversation with @sunfishcode yesterday, who pointed out that if we're going to add timezones to wasi:clocks (WebAssembly/wasi-clocks#61), wasi:http/proxy may not actually want to provide timezone support.

By switching from a catch-all include to individual import statements, we can decide later whether this is something we'd like to include. But conservatively we can start with the assumption that we won't.

This has some precedent in how we're handling our re-exports of wasi:cli: wasi:http/proxy includes wasi:cli/stdin and wasi:cli/stdout - but it does for example not include support for files or sockets.

@lukewagner
Copy link
Member

Makes sense to me

@yoshuawuyts yoshuawuyts force-pushed the unblanket-wasi-clocks-import branch from fdfcc05 to 329d9ff Compare July 17, 2024 00:03
@yoshuawuyts yoshuawuyts requested a review from lukewagner July 17, 2024 00:05
@lukewagner lukewagner merged commit b8fdd99 into WebAssembly:main Jul 17, 2024
1 check passed
@yoshuawuyts yoshuawuyts deleted the unblanket-wasi-clocks-import branch July 17, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants