-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate wasm-c-api on big-endian and fix rot13 test #2161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If thats all it takes to support these platforms its seems reasonable to me.
ENV TZ=UTC | ||
|
||
RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && \ | ||
echo $TZ > /etc/timezone && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why this TZ hacking is needed.. seems a little odd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea, ask #1971 ? this PR is based on that one.
this should not have broken the main build... where's the typo? >.< |
found the typo XD |
This comment was marked as resolved.
This comment was marked as resolved.
4264e91
to
0921fb3
Compare
it's possible these were always broken, but, uh, anyone wanna bisect these remaining failures? edit: okay so simd and atomics are something we'll have to fix (in a separate PR). we're not sure about the failing traps tho. also, i386 support is not up to us. |
perhaps cc @rathann about i386/i686? also @alexreinking do you know anything about using a cross-compiler with these? running the whole compiler under qemu seems unnecessarily slow... |
x86_64 builds of gcc can compile for i686 without qemu or cross-compilation. |
This includes #1971 and fixes #1972
Rationale in #1972 (comment)