Rename v8x16.shuffle to v8x16.shuffle2_imm #1053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That SIMD spec proposal change was merged explicitly without consensus on the instruction names. I think toolchain updates could wait until we actually have a discussion on the new names, since I don’t think the current temporary names are any more stable than the previous names. |
|
We can leave this on hold, I understood from the discussion that the new names had consensus, but if not, we can leave this PR open and maybe try to achieve consensus on the next meeting about the names. |
|
I believe the changes in this PR have now landed here: c36c95d. If not, feel free to send a new PR with the missing parts. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To conform to the latest SIMD draft, see: WebAssembly/simd#71