Add limitations section to Linking.md to clarify element and data segment indices renumbering is not supported (#193) #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Dec 5, 2022
Linking.md
Outdated
|
|
||
| ### Limitations | ||
|
|
||
| Note data segments are only re-positioned, i.e. only the offsets of active data |
There was a problem hiding this comment.
How about rephasing this as.
- There is currently no support for passive data segments. The relocation types necessary for referencing such segments (e.g. in `data.drop` or `memory.init` instruction) do not yet exist.
- There is currently no support for table element segments, either active or passive.
There was a problem hiding this comment.
I like your reformulation, clear and to the point. I've updated the PR.
…ment indices renumbering is not supported (WebAssembly#193)
sbc100
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #193.