Rename round to nearestint. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not for this PR, but it would be good to test that this is indeed the behavior of the ML prototype. |
|
It's in the TestingTodo.md already :-) :
|
|
LGTM, but why not simply name it "Nearest"? The Int suffix seems kind of redundant and inconsistent with the other float rounding operators. |
It's useful to avoid calling it "round" because it's semantically different from both JS's Math.round and C's round.
sunfishcode
force-pushed
the
nearestint
branch
from
5b045c0 to
9300cfe
Compare
|
I'm ok with "nearest". I updated the PR accordingly. |
sunfishcode
added a commit
to WebAssembly/design
that referenced
this pull request
Sep 2, 2015
littledan
pushed a commit
to littledan/spec
that referenced
this pull request
Mar 4, 2018
The new names are: - `i32.extend8_s` - `i32.extend16_s` - `i64.extend8_s` - `i64.extend16_s` `i64.extend32_s` has also been added for consistency. See issue WebAssembly#34.
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Sep 18, 2019
Increase the table count limit to 100,000
ErikMcClure
pushed a commit
to innative-sdk/spec
that referenced
this pull request
Jun 15, 2020
In particular, remove an invalid assertion and take into account that WebAssembly functions always return a list of results.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 3, 2023
Add explicit RTT support for casts
dhil
added a commit
to dhil/webassembly-spec
that referenced
this pull request
Jul 31, 2024
This patch fixes the continuation subtyping issue. Resolves wasmfx#35.
rossberg
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what the design repo calls it. And in particular, it's useful to
avoid calling it "round" because it's semantically different from both
JS's Math.round and C's round.