use dune in the Makefile and remove ocamlbuild #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngzhian
reviewed
Jun 19, 2023
rossberg
reviewed
Jun 20, 2023
There was a problem hiding this comment.
Changes look good mostly, but you may have been a bit over-aggressive in deleting stuff. At least I wouldn't know how to build the opam library package anymore after this. ;)
Is there a way to avoid and work around the renaming main.ml→wasm.ml? IMO it's bad design that dune assumes this.
zapashcanon
force-pushed
the
makefile
branch
2 times, most recently
from
cd163ee
to
4ee754b
Compare
I did something for this. Everything should be OK now @rossberg. :) |
rossberg
approved these changes
Jun 26, 2023
rossberg
reviewed
Jul 24, 2023
|
It should be good now @rossberg ? |
rossberg
reviewed
Jul 24, 2023
rossberg
requested changes
Jul 25, 2023
rossberg
reviewed
Jul 25, 2023
rossberg
approved these changes
Jul 25, 2023
Co-authored-by: Andreas Rossberg <[email protected]>
rossberg
approved these changes
Jul 26, 2023
|
I merged it, thanks for taking this. |
foolip
added a commit
to foolip/spec
that referenced
this pull request
Oct 6, 2023
It ought to not be needed after WebAssembly#1665.
rossberg
pushed a commit
that referenced
this pull request
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As discussed in #1664, I switched everything from
ocamlbuildtodune, I removed winmake.bat along the way. I made a lot of simplifications in the Makefile but also removed a few things: we don't build the bytecode version anymore and we don't copy the executable at the root anymore.