Makefile improvements #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
The debug build has much more extensive backtraces, and since performance isn't really important for the spec interpreter, would it make sense to make the debug build be the default? |
|
Done
|
|
lgtm |
|
The issue I see now is that |
|
Hm, okay, will look into that.
|
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Jul 18, 2019
* [spec] Add exec text * Update document/core/exec/instructions.rst Co-Authored-By: Andreas Rossberg <[email protected]> * Update document/core/exec/instructions.rst Co-Authored-By: Andreas Rossberg <[email protected]> * Update document/core/exec/instructions.rst Co-Authored-By: Andreas Rossberg <[email protected]> * Apply suggestions from code review Co-Authored-By: Andreas Rossberg <[email protected]>
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Nov 18, 2019
Clarifies that low lanes are lanes [0, n/2) and high lanes are [n/2, n) and that the order of arguments to the narrowing ops are (low, high). This matches the current implementation in V8.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Sep 20, 2023
rossberg
pushed a commit
that referenced
this pull request
Jan 20, 2025
* Test largest valid initial size for memory32 in memory.wast * Only validate and don't instantiate large memory
dhil
added a commit
to dhil/webassembly-spec
that referenced
this pull request
Feb 18, 2025
This patch fixes a bug with the arity of the continuation reference generated by a `switch` (aka the current continuation). Its arity was mistakenly derived from the switch-tag's codomain. The arity of the current continuation can be obtained at the `switch` point by deconstructing the type annotation on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main.nativeandmain.d.byteas intermediate targets.This should address issue #102 .