Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array.get/set reduction rule #464

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix array.get/set reduction rule #464

merged 1 commit into from
Nov 3, 2023

Conversation

ShinWonho
Copy link
Contributor

Trap case of array.get and array.set is omitted or wrongly described.

Screenshot 2023-11-03 at 2 29 04 PM Screenshot 2023-11-03 at 2 29 29 PM
  • Current specification
Screenshot 2023-11-03 at 2 28 46 PM Screenshot 2023-11-03 at 2 30 09 PM
  • Suggested change

rossberg
rossberg approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

rossberg
rossberg approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

@rossberg rossberg merged commit 78d73e8 into WebAssembly:main Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossberg rossberg rossberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShinWonho @rossberg