Spec sequential visibility for globals #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Sep 9, 2023
document/core/valid/modules.rst
Outdated
| \frac{ | ||
| C \vdashglobal \global_1 : \X{gt}_1 | ||
| \qquad | ||
| C, \CGLOBALS~\X{gt}_1 \vdashglobalseq \global^\ast : \X{gt}^\ast |
There was a problem hiding this comment.
Since context extension was originally defined with labels in mind, it prepends the new items to the relevant index space in the context, but here we want to append the new global to the end of the index space. It seems we need to define separate notations for prepending and appending extension, or else define a convention that extension prepends for labels and appends for everything else.
There was a problem hiding this comment.
Ah, yes, good catch. I'll probably redesign that at some point, but for now I'm using \compose instead here.
tlively
reviewed
Sep 9, 2023
document/core/valid/modules.rst
Outdated
| @@ -802,8 +833,7 @@ The :ref:`external types <syntax-externtype>` classifying a module may contain f | |||
| However, this recursion is just a specification device. | |||
| All types needed to construct :math:`C` can easily be determined from a simple pre-pass over the module that does not perform any actual validation. | |||
|
|
|||
| Globals, however, are not recursive and not accessible within :ref:`constant expressions <valid-const>` when they are defined locally. | |||
| The effect of defining the limited context :math:`C'` for validating certain definitions is that they can only access functions and imported globals and nothing else. | |||
| Globals, however, are not recursive but eveluated sequentially, such that each :ref:`constant expressions <valid-const>` only has access to imported or priviously defined globals. | |||
There was a problem hiding this comment.
Suggested change
| Globals, however, are not recursive but eveluated sequentially, such that each :ref:`constant expressions <valid-const>` only has access to imported or priviously defined globals. | |
| Globals, however, are not recursive but evaluated sequentially, such that each :ref:`constant expressions <valid-const>` only has access to imported or previously defined globals. |
|
@tlively, PTAL. |
tlively
approved these changes
Sep 10, 2023
|
It's already described there. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a couple of respective test cases.