Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GC.md #1080

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Remove GC.md #1080

merged 1 commit into from
Jul 13, 2017

Conversation

jfbastien
Copy link
Member

We should removing GC.md as part of #1066. It's more aspirational that concrete, and we're now tracking GC work with #1079 as well as in https://github.com/WebAssembly/gc/.

Caveat before removing this:

  • Other pages link to it. I'll clean up.
  • Some of the content may still be valid. We should move it to the GC proposal instead so it doesn't become stale.

We should removing GC.md as part of #1066. It's more aspirational that concrete, and we're now tracking GC work with #1079 as well as in https://github.com/WebAssembly/gc/.

Caveat before removing this:

* Other pages link to it. I'll clean up.
* Some of the content may still be valid. We should move it to the GC proposal instead so it doesn't become stale.
@jfbastien jfbastien requested review from rossberg and lukewagner May 25, 2017 22:35
@jfbastien
Copy link
Member Author

Luke / Andreas: what do you think should be moved to the GC proposal from this page?

@lukewagner
Copy link
Member

Yeah, GC.md was just a stopgap early on when the question kept coming up.

@jfbastien
Copy link
Member Author

Is there anything you think should be migrated to https://github.com/WebAssembly/gc/blob/master/proposals/gc/Overview.md ?

@lukewagner
Copy link
Member

I guess, now that you mention it, the "JS integration" and "WebIDL integration" subsections would be separate proposals (that build on top of gc/Overview.md). They're just sketches though (and a bit antiquated by now), so out of place w.r.t the rest of the design repo, which describes the shipping status quo. So I'm fine removing them.

@jfbastien
Copy link
Member Author

I can move them to a tracking issue in the design repo.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Moving JS/Web stuff to issues sounds fine with me.

@rektide
Copy link

rektide commented Jun 9, 2017

Even if it's a place-holder, having some kind of information available that links WebAssembly to the rest of the Web Platform seems like a really good healthy thing. I'd expect that not having this would cause a lot of silent head scratching and create a support burden for randos like me wandering in wondering what the story is.

I'd like to see a very minimal gc/JS.md and/or gc/WebIDL.md created before dropping GC.md, even if just a placeholder, to prevent confusion from spreading. It's important to leave some kind of stake in the ground here. Links in these documents to a tracking issue would be appropriate and helpful.

@jfbastien jfbastien merged commit 9a6d9d5 into master Jul 13, 2017
@jfbastien jfbastien deleted the jfbastien-patch-6 branch July 13, 2017 12:28
j3parker added a commit to j3parker/design that referenced this pull request Aug 12, 2017
This file was removed in commit ebf4244,
from pull request WebAssembly#1080
jfbastien pushed a commit that referenced this pull request Aug 12, 2017
This file was removed in commit ebf4244,
from pull request #1080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants