Require an ok status for a response #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once there's a more formal specification we should deduplicate this. |
This changes both WebAssembly.compile and WebAssembly.instantiate to be both more clear about response requirements and require an ok status. Fixes #1039.
annevk
force-pushed
the
annevk/response-requirements
branch
from
fe7a092 to
1ea453f
Compare
mtrofin
approved these changes
May 12, 2017
| @@ -60,15 +60,18 @@ as described in the [`WebAssembly.Module` constructor](#webassemblymodule-constr | |||
| On success, the `Promise` is [fulfilled](http://tc39.github.io/ecma262/#sec-fulfillpromise) | |||
| with the resulting `WebAssembly.Module` object. On failure, the `Promise` is | |||
| [rejected](http://tc39.github.io/ecma262/#sec-rejectpromise) with a | |||
| `WebAssembly.CompileError`. | |||
| `WebAssembly.CompileError` or `TypeError`, depending on the type of failure. | |||
There was a problem hiding this comment.
Nit: should we say "depending on the type of failure, as it will be clarified further below"
... or something to that extent?
There was a problem hiding this comment.
I went with what we had for instantiate, but happy to change both in this manner if others agree. Eventually we need to redo both these descriptions in a more formal matter once you all figure out how you want to define your objects (see #1048).
|
Anyone else have any feedback? |
jfbastien
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes both WebAssembly.compile and WebAssembly.instantiate to be
both more clear about response requirements and require an ok status.
Fixes #1039.