Restrict namespace and package names to lowercase words #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Apr 11, 2024
lukewagner
force-pushed
the
restrict-ns-pkg-names
branch
from
ef574dd to
5cdf885
Compare
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Apr 18, 2024
github-merge-queue bot
pushed a commit
to bytecodealliance/wasm-tools
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the restriction discussed in #299. While (with #337) case-insensitive uniqueness does allow a registry of components or WIT packages to lowercase everything without collision, enforcing case-insensitive uniqueness (on publication) may end up requiring non-trivial extra work (e.g., maintaining a whole side index) if the registry is implemented on top of an existing infrastructure (say, an OCI registry). This also avoids some corner cases that will likely turn into incompatibilities in core infrastructure.