Rename float32/float64 to f32/f64.
#324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `float32` and `float64` types are being [renamed to `f32` and `f64`]. All the main tools have been updated to accept both old and new names for now, so there's no urgency to change anything, but users who wish to can now start switching to the new `f32`/`f64` names. [renamed to `f32` and `f64`]: WebAssembly#277
lukewagner
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Thanks for doing this! Could you also s/Float32/F32/ and s/Float64/F64/ in CanonicalABI.md and canonical-abi/definitions.py?
In terms of merging into this repo: if the tools are already updated to accept f32/f64, then it seems like we can merge (after a day or two for final comments); is that right?
|
|
|
(Oops, I forgot to merge this earlier.) |
ydnar
added a commit
to bytecodealliance/go-modules
that referenced
this pull request
Apr 4, 2024
ianprime0509
added a commit
to ianprime0509/zig-wit
that referenced
this pull request
Apr 7, 2024
sunfishcode
added a commit
to sunfishcode/wasm-tools
that referenced
this pull request
Dec 3, 2024
The component-model type "float32" was [renamed to "f32"], so rename Wave's type to match. [renamed to "f32"]: WebAssembly/component-model#324
github-merge-queue bot
pushed a commit
to bytecodealliance/wasm-tools
that referenced
this pull request
Dec 3, 2024
The component-model type "float32" was [renamed to "f32"], so rename Wave's type to match. [renamed to "f32"]: WebAssembly/component-model#324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
float32andfloat64types are beingrenamed to
f32andf64. All the main tools have been updated to accept both old and new names for now, so there's no urgency to change anything, but users who wish to can now start switching to the newf32/f64names.