Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parser] Avoid an internal assertion when a function's type does not match params #7247

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

kripken
Copy link
Member

@kripken kripken commented Jan 29, 2025

The parser trusted the type when calling setLocalName, but that method
asserts of the local index is invalid. Avoid that assertion so we reach the
proper error message later.

@kripken kripken requested a review from tlively January 29, 2025 00:52
test/lit/parse-error-func-param-type.wast Outdated Show resolved Hide resolved
@kripken kripken merged commit 9498d5e into WebAssembly:main Jan 29, 2025
13 checks passed
@kripken kripken deleted the parse.error.func.param branch January 29, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants