wasm-emscripten-finalize: Add mainReadsParams metadata #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch will let us avoid emitting JS to set up argc/argv if they are never used.
kripken
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Jul 22, 2019
…#9045) This change avoids the binaryen addition of the flags causing tests to break, as we assert on surprising flags in emscripten.py. It sets the value of that param to a pessimistic 1 (assume main does read its params). This does nothing for now. After this lands, the binaryen PR [1] can land, and then a PR that adds the actual optimization and testing here. [1] WebAssembly/binaryen#2247
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…emscripten-core#9045) This change avoids the binaryen addition of the flags causing tests to break, as we assert on surprising flags in emscripten.py. It sets the value of that param to a pessimistic 1 (assume main does read its params). This does nothing for now. After this lands, the binaryen PR [1] can land, and then a PR that adds the actual optimization and testing here. [1] WebAssembly/binaryen#2247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new flag indicates whether main reads the argc/argv parameters. If it does not, we can avoid emitting code to generate those arguments in the JS, which is not trivial in small programs - it requires some string conversion code.
Nicely the existing test inputs were enough for testing this (see outputs).
This depends on an emscripten change to land first, as emscripten.py asserts on metadata fields it doesn't recognize.