-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
witx: Parse comments into documentation in AST #140
Conversation
fd08460
to
0003c77
Compare
Todo:
|
👍 I whipped up a small render function which I think should do the trimming/doc comment parsing, and I think this looks like it might work well! I'll make a release of the |
a5e5746
to
b3fd267
Compare
I've got this PR to a point where I think it should be reviewed and merged:
|
Merge conflicts resolved. After we do a snapshot, I'll resolve the conflicts one more time and then merge. |
and rename the path to be a litle shorter
Derived from ca26654f7747e2c9ce9d80d05c23a4ed48ec126c in https://github.com/alexcrichton/wat (PR #26)
sed -i -E "s/ ;; / ;;; /" **/*.witx sed -i -E "s/^;; /;;; /" **/*.witx
this was stopping the roundtripping test from passing, since the whitespace in the AST is slightly different after a roundtrip. I am not feeling clever enough to think of an elegant solution now, so I'll just hack up these files to not hit the bug.
c84a40e
to
775bfa2
Compare
Just rebased on #145 - will merge once that one is in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proof of concept to show that https://github.com/alexcrichton/wat/pull/26/ is a viable approach