Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add core kit key #69

Merged
merged 20 commits into from
Jun 6, 2023
Merged

Feat/add core kit key #69

merged 20 commits into from
Jun 6, 2023

Conversation

arch1995
Copy link
Contributor

@arch1995 arch1995 commented Mar 20, 2023 •
edited
Loading

  • Support coreKitKey
  • Upgrade dep
  • Adds a new working example
  • Rewrites the SDK class with new getters
  • Fixes the issue in logout API (It wasn't working)

TODO:

  • Add shims in the sdk itslef
  • Adds crypto.getRandomValues in the shims file (Required for encryptData)

@Mostafatalaat770
Copy link

any updates on this?

chaitanyapotti
chaitanyapotti approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 3db4820 into master Jun 6, 2023
@chaitanyapotti chaitanyapotti deleted the feat/add-core-kit-key branch June 6, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arch1995 @Mostafatalaat770 @chaitanyapotti @shahbaz17 @yashovardhan